Remove -Zlink-native-libraries=no from RUSTFLAGS#42
Open
hoodmane wants to merge 1 commit intopyodide:mainfrom
Open
Remove -Zlink-native-libraries=no from RUSTFLAGS#42hoodmane wants to merge 1 commit intopyodide:mainfrom
-Zlink-native-libraries=no from RUSTFLAGS#42hoodmane wants to merge 1 commit intopyodide:mainfrom
Conversation
The upstream bug that made this necessary seems to have been resolved: emscripten-core/emscripten#16680
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
Oct 16, 2024
ryanking13
approved these changes
Oct 18, 2024
Member
ryanking13
left a comment
ryanking13
left a comment
There was a problem hiding this comment.
Nice! Thanks @hoodmane.
Could you please update the changelog? I think mentioning the Emscripten version that resolved this issue would be useful... but I am not sure which version of Emscripten actually fixed it.
Member
Author
|
I have no idea either, it will require a bisect... |
Member
Author
|
Also, ironically now |
Member
No problem. We haven't updated the Emscripten version in Pyodide for a while, so it should be safe to conclude that it works in Pyodide >= 0.26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream bug that made this necessary seems to have been resolved:
emscripten-core/emscripten#16680